[Authlib] Fix AsyncOAuth2Client missing async context manager methods.#15190
Open
robertuss12 wants to merge 1 commit intopython:mainfrom
Open
[Authlib] Fix AsyncOAuth2Client missing async context manager methods.#15190robertuss12 wants to merge 1 commit intopython:mainfrom
robertuss12 wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
|
Thanks you! |
Author
|
I tracked down the cause of the stub_uploader error but hit a wall on fixing it. Thanks for pinning that ticket, @donbarbos — good to know it wasn't something I broke! Question: does my PR need to wait for #190, or is there a way to bypass this check? |
Contributor
maas-lander
pushed a commit
to canonical/maas
that referenced
this pull request
Jan 13, 2026
Pyright version 1.1.408 has introduced an issue where it doesn't recognize AsyncOAuth2Client as an httpx.AsyncClient. The issue relies on typeshed: python/typeshed#15190. To avoid tests failures and adding unnecessary ignore directives to the code, let's pin the version to 1.1.407 and remove it once the bug is fixed.
r00tabot
pushed a commit
to SpaghettiHub/maas
that referenced
this pull request
Jan 13, 2026
Pyright version 1.1.408 has introduced an issue where it doesn't recognize AsyncOAuth2Client as an httpx.AsyncClient. The issue relies on typeshed: python/typeshed#15190. To avoid tests failures and adding unnecessary ignore directives to the code, let's pin the version to 1.1.407 and remove it once the bug is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After recent changes to
Authlibintegrations,mypycomplains thatAsyncOAuth2Clienthas no attribute__aenter__and__aexit__when used as an async context manager.I've looked into it and found that
AsyncOAuth2Clientinherits these methods fromhttpx.AsyncClient, but this inheritance is not reflected in the stub file. I've tried to fix it and added a test.I had some problems with pyright tests - I couldn't get it to work without explicitly adding the
__aenter__method. I don't know why, as I haven't used pyright before. If this is a result of issues in my local environment (that's my suspicion due to other problems like unknown imports) and the explicit method is unnecessary, please let me know.